MediaWiki talk:Kartographer.js

From Wikivoyage
Jump to navigation Jump to search

Markers without tool tips[edit]

Markers of nearby articles can produce a popup window but they have no tooltips (html title attribute). --RolandUnger (talk) 15:22, 13 July 2016 (UTC)[reply]

RolandUnger, this code has migrated to the Kartographer extension, and will be removed fairly soon from here. Please file a phab ticket. Thx! --Yurik (talk) 15:46, 13 July 2016 (UTC)[reply]

Make HTTPS[edit]

Most of these tile servers support https. Using https is best practice generally. Additionally, not using https is causing browsers to give a (passive) mixed content warning. May I suggest changing to https all the layers that support that? I also filed phab:T244688 about this. Bawolff (talk) 07:35, 10 February 2020 (UTC)[reply]

Updating the external sources[edit]

I was looking a bit at this and some updates are needed.

  1. All thunderforest urls can now use https instead of http. This is better for privacy
  2. OpenPTmap no longer seems to exist. So the entire block for it can be removed (thunderforest could be a replacement)
  3. The boundaries map also no longer exists, so the entire "boundaries" block can be removed
  4. Both the cycling and the hiking maps can be update to http and should for privacy reasons

Also of note is that currently the English wikivoyage nearby articles list is return invalid javascript, causing none of the poi's to load... Not sure how long it has been like that, and I can't really fix it. If its broken very long, then maybe that should be removed at some point.

Anyway, new version here, changes in the diff. ping User:Andyrom75 and User:WOSlinker as IAs. TheDJ (talk) 18:32, 24 April 2021 (UTC)[reply]

TheDJ, should the https://tools.wmflabs.org/wikivoyage/w/data/en-articles.js url be updated to https://wikivoyage.toolforge.org/w/data/en-articles.js for the nearby articles list as well? -- WOSlinker (talk) 20:45, 24 April 2021 (UTC)[reply]
You should remove .overlay( 'boundaries' ), too. --RolandUnger (talk) 07:42, 25 April 2021 (UTC)[reply]
Both good suggestions ! TheDJ (talk) 18:30, 25 April 2021 (UTC)[reply]
I've applied those changes. -- WOSlinker (talk) 19:52, 25 April 2021 (UTC)[reply]

Request to remove obsolete nearby code[edit]

Hi Wikivoyage! The Wikimedia Deutschland Technical Wishes Team introduced a new nearby feature that's the default on all wikis for some time now. The original nearby feature that was mostly exclusive to Wikivoyage wikis got disabled with that. Now that some time has passed we would like to clean up the involved extension and remove old code that was responsible for the original feature. For that it is required that no scripts or gadgets try to access the outdated code. So I'm kindly requesting the removal of the following parts in this script:

 * - Adds a control (top left) to show the Nearby Articles from Wikivoyage.
nearbyArticlesCfg = {
	url: 'https://wikivoyage.toolforge.org/w/data/en-articles.js',
	thumbPath: '//upload.wikimedia.org/wikipedia/commons/thumb/'
},
wv.NearbyArticles.setConfig( nearbyArticlesCfg );
wvmap.nearby();

Thanks in advance -- Christoph Jauera (WMDE) (talk) 08:17, 11 October 2023 (UTC)[reply]

Interface admin edit request[edit]

Swept in from the pub

My team at Wikimedia Deutschland left an edit request at MediaWiki talk:Kartographer.js#Request to remove obsolete nearby code that probably got lost because not many people are actively watching such technical pages. While this is in no way urgent it would enable us to clean up the Kartographer codebase. Thanks in advance. --Thiemo Kreuz (WMDE) (talk) 12:30, 26 October 2023 (UTC)[reply]

@Andyrom75:? SHB2000 (talk | contribs | meta) 12:36, 26 October 2023 (UTC)[reply]
@Thiemo Kreuz (WMDE), I've overwritten MediaWiki:Kartographer.js with it:MediaWiki:Kartographer.js that I've previously updated with the support of @Christoph Jauera (WMDE). Please check and confirm that now is fine.
@SHB2000, thanks for the ping. Andyrom75 (talk) 13:01, 26 October 2023 (UTC)[reply]