MediaWiki talk:MoveArticleStates.js
Jump to navigation
Jump to search
Use of "addOnloadHook" is deprecated. Use jQuery instead[edit]
I get this error message when the browser loads pages on Wikivoyage. Could an administrator change the last line from
addOnloadHook(moveArticleStates);
to
$(moveArticleStates);
Thanks, Chmarkine (talk) 21:29, 22 March 2014 (UTC)
- I've made this change, but if I'm reading the code correctly I think it just moves the map icon over to allow more space for DOTM icons, which we no longer include in the header. As a result I think this Javascript can be disabled. Would there be any objections to doing so? -- Ryan • (talk) • 22:31, 22 March 2014 (UTC)
- I've removed this script from MediaWiki:Common.js. If anyone sees any unexpected side effects please restore it. -- Ryan • (talk) • 00:18, 25 March 2014 (UTC)
- Thanks Ryan! It seems that it is fine to remove this script. Chmarkine (talk) 01:16, 25 March 2014 (UTC)
- I've removed this script from MediaWiki:Common.js. If anyone sees any unexpected side effects please restore it. -- Ryan • (talk) • 00:18, 25 March 2014 (UTC)
Obsolete script[edit]
Ryan I think this script can be deleted because it's not used anymore. Is an old (2012) script created by de:voy and it has been deleted there too. PS I've deleted it also in it:voy on 2013. --Andyrom75 (talk) 08:37, 4 September 2016 (UTC)
- I've added comments noting that it is obsolete / unused. I'm not sure whether it makes more sense to delete it, find a place to archive it (since it is reference in article histories), or leave it as-is. Does anyone know how Wikipedia would handle an obsolete script like this? -- Ryan • (talk) • 16:29, 5 September 2016 (UTC)
- I don't know personally what Wikipedia does, but IMHO keep obsolete/unused scripts in MediaWiki NS, within all the others in use, makes only confusion, complicating life to maintainers. --Andyrom75 (talk) 17:31, 5 September 2016 (UTC)