Template talk:Banner

From Wikivoyage
Jump to navigation Jump to search
See also: Wikivoyage:UX_Expedition#Feature_Banner

Pagebanner visualization bug[edit]

Swept in from the pub

In diff pages like this one, the pagebanner is not shown. --Andyrom75 (talk) 17:57, 24 September 2016 (UTC)Reply[reply]

Who is charge ti fix issues on this extension? --Andyrom75 (talk) 12:06, 26 September 2016 (UTC)Reply[reply]
The preview page suffer the same bug. It's particularly annoying when an user change the banner imagine, because it's not possible to see it before saving. A Phab bug should be opened. --Andyrom75 (talk) 14:56, 8 October 2016 (UTC)Reply[reply]
Preview bug has been solved, but since no one has still corrected the diff one, I've opened a ticket. --Andyrom75 (talk) 17:55, 12 October 2016 (UTC)Reply[reply]

Prepare for T314318[edit]

Hi,

This is concerning the thread at Wikivoyage:Travellers'_pub#Images

Can someone make this forward / backwards compatible change to Template:Banner/styles.css in preparation of enabling those changes to image rendering? It shouldn't have any effect yet, since span[typeof~='mw:File/Frameless'] isn't output at present.

51c51,52
< 	.banner-image img.nolink { display: none; }
---
> 	.banner-image img.nolink { display: none; } /* can be removed when backward compat is no longer needed */
> 	.banner-image span[typeof~='mw:File/Frameless'].nolink { display: none; }
76c77,79
< 	.banner-image img:not(.nolink) { display: none; }
---
> 	.banner-image img:not(.nolink) { display: none; }  /* can be removed when backward compat is no longer needed */
> 	.banner-image span[typeof~='mw:File/Frameless'] img { display: inline-block; } /* can be removed when b/c is no longer needed */
> 	.banner-image span[typeof~='mw:File/Frameless']:not(.nolink) { display: none; }
101,102c104,106
< 	}
< 	.interactiveIcon {
---
> 	
> 	img.interactiveIcon, /* can be removed when backward compat is no longer needed */
> 	.interactiveIcon img {

There's some explanation of the reason for this change at mw:Parsoid/Parser_Unification/Media_structure/FAQ#The_|class=_media_option_is_now_applied_to_the_wrapper

Thank you, Arlolra (talk) 21:34, 13 September 2022 (UTC)Reply[reply]

Maybe this is a better diff,
https://en.wikivoyage.org/wiki/Special:ComparePages?page1=Template%3ABanner%2Fstyles.css&rev1=&page2=User%3AArlolra%2Fsandbox%2FBannerstyles.css&rev2=&action=&unhide= Arlolra (talk) 21:43, 13 September 2022 (UTC)Reply[reply]
Yes Done it's been over a week so I used my sysadmin access to implement it. Legoktm (talk) 00:59, 21 September 2022 (UTC)Reply[reply]