MediaWiki talk:Gadget-ListingEditor2023.js

From Wikivoyage
Latest comment: 25 days ago by Andyrom75 in topic TODO
Jump to navigation Jump to search

TODO

[edit]

Listing Editor issue on it:voy

[edit]

@Jdlrobson, the gadget stop working on it:voy.

In order to minimize similar issues, please inform me before deploying a patch so I can test it in advance. Thanks, Andyrom75 (talk) 15:53, 18 July 2024 (UTC)Reply

Hey there I just had to disable the gadget with my staff hat on because it was logging an error for every page view.
Back with my volunteer hat on, I haven't updated the gadget in about 2 weeks and even then most of those changes have not been major. Is it possible you are hitting issues with the heading roll out issue on https://www.mediawiki.org/wiki/Heading_HTML_changes . This makes me think it's setup incorrectly.
Looks like you are loading the gadget incorrectly using action=raw rather than load.php in https://it.wikivoyage.org/wiki/MediaWiki:Gadget-ListingEditor2023.js
Untested but switching
importScriptURI('https://en.wikivoyage.org/w/index.php?title=MediaWiki:Gadget-ListingEditor2023.js&action=raw&ctype=text/javascript');
with
importScriptURI('https://en.wikivoyage.org/w/load.php?modules=ext.gadget.ListingEditor2023');
might fix it! Jdlrobson (talk) 18:41, 18 July 2024 (UTC)Reply
@Jdlrobson, I don't know exactly when the problem occurs, I've just been alerted yesterday by a user.
I've just substitute in it:MediaWiki:Gadget-ListingEditor2023.js the line you wrote initially with the one you suggested.
I'll wait for some minutes to be sure that the cache won't affect the result of the test, then I'll try to rollback the most recent changes on Listing Editor script to verify if the problem is in this script or elsewhere. Andyrom75 (talk) 05:35, 19 July 2024 (UTC)Reply
@Jdlrobson, now it works, thanks. I've restored the default parameter on the "alpha" version.
Could you please support to implement also the "beta" version on it:voy? I've done some tentatives, but I didn't succeed. Andyrom75 (talk) 10:19, 19 July 2024 (UTC)Reply
Apparently I've implemented it, but in a different way it has been done here on en:voy, could you check if it's equivalent or if there's any mistake? Andyrom75 (talk) 14:50, 22 July 2024 (UTC)Reply

Coordinates format

[edit]

@Jdlrobson, I've just noticed that Listing Editor doesn't accept anymore all the various coordinates formats (e.g. 39°22′32″N). Could you check and restore the original function or eliminate the control that prevent to proceed? Thanks, Andyrom75 (talk) 06:37, 16 October 2024 (UTC)Reply

@Jdlrobson, @Jon (WMF), please confirm the receipt of the message. Andyrom75 (talk) 07:13, 24 October 2024 (UTC)Reply

Fixed

[edit]

Sync issue with Wikidata

[edit]

Yes Https://github.com/jdlrobson/Gadget-Workshop/issues/4

@Jdlrobson, there's a problem with the listing "Bastione Conca" present in Trapani. Clicking on "Sync shared fields to/from Wikidata", doesn't appear any popup, neither the one to change the parameter, nor the one that state that all is aligned.

The only difference I see with other Wikidata instance, is the absence of coordinates in Wikidata. Please check it and let me know. Andyrom75 (talk) 18:27, 21 July 2024 (UTC)Reply

I think this is the same issue tracked in https://github.com/jdlrobson/Gadget-Workshop/issues/4 - I haven't been able to look at that feature yet. The code is pretty complicated so I haven't managed to reverse-engineer it. Jdlrobson (talk) 21:36, 21 July 2024 (UTC)Reply
@Jdlrobson, look at it:Trapani#Castello di Terra (Item 13). It works correctly.
I've cloned it twice:
  • Item 15: the same but with the image of Item 14 ("Bastione Conca")
  • Item 16: identical to Item 13.
All the three items use the same Wikidata instance.
Item 16 works correctly as Item 13, while Item 15 has the same issue of "Bastione Conca".
Could you check if the problem is on the parsing logic? Andyrom75 (talk) 14:47, 22 July 2024 (UTC)Reply
I hope you'll have soon some spare time to give a look at it. In the meanwhile, I remove the 2 "test listing" I've inserted to show you the issue.
Just to avoid that I'll forget to clean the article in the future :-) Andyrom75 (talk) 12:20, 25 July 2024 (UTC)Reply
@Jdlrobson, sorry, I forgot the ping :-) Andyrom75 (talk) 21:23, 25 July 2024 (UTC)Reply