Module talk:Exchangerate

Price ranges broken

@Marsupium: Please review your recent edits. The module is no longer working at converting price ranges. See Caldas da Rainha#Eat for numerous examples. Thank you. --Nelson Ricardo (talk) 11:33, 11 January 2022 (UTC)

Thanks a lot for pointing this out! I hadn't studied the code of Template:Exchangerate enough, I'm sorry! I hope now it's fixed with this edit. Best, --Marsupium (talk) 12:03, 11 January 2022 (UTC)

Thank you, @Marsupium. The error message appears to be resolved. --Nelson Ricardo (talk) 12:31, 11 January 2022 (UTC)

I hope so, Category:Pages with script errors has calmed town at least. --Marsupium (talk) 13:54, 11 January 2022 (UTC)

Source of exchange rates

Thank you for an amazing module! I wonder, where you take exchange rates? (Couldn't find the source in the code) Soshial (talk) 03:58, 23 May 2022 (UTC)

Hello Soshial, thanks a lot for the appreciation! It means a lot to me especially after having kinda opposite experiences on completely different Wikimedia projects that might have partly made me more involved here and on German Wikivoyage at the moment. :-)

It has turned out that the module has quite some issues and current discussion about it is on de:Benutzer_Diskussion:Marsupium#Wechselkursdaten and de:Benutzer Diskussion:DerFussi#tabularData if you can find some way to read the German (if you want to jump in, I could imagine everyone involved would be happy to switch to English as well.

To answer your question: See Module:Exchangerate/doc#Module status or Module:Exchangerate#L-90. Data comes from c:Data:ECB euro foreign exchange reference rates.tab and c:Data:Xe.com exchange rates.tab. It is there thanks to @GiftBot who takes it from https://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml and https://www.xe.com/currencyconverter/ (which are listed there).

I guess that you might be interested especially in Georgian lari that isn't given by those two sources. I was thinking about adapting bot-rates.py by Superzerocool to create a table from https://free.currencyconverterapi.com/ (no idea where they get their data from) so that we could create a table like c:Data:Xe.com exchange rates.tab for the currencies supported there (which include GEL) at least once daily. Unexpectedly, I'll be very busy in real life for the foreseeable future and won't be able to do that myself, but maybe Superzerocool could help with that or anyone with scripting knowledge in python or something else and set up the automatic runs. Best, --Marsupium (talk) 05:54, 24 May 2022 (UTC)

Range dash not working

For some reason, it seems {{currency}} uses a hyphen instead of an n-dash for ranges, such as €30-40, despite the n-dash in line 136:

converted = first and second and first .. '–' .. second

Could somebody figure out what's wrong?

–LPfi (talk) 10:47, 7 November 2023 (UTC)