Wikivoyage talk:Listing editor

From Wikivoyage
Jump to navigation Jump to search

Archived discussions

Issue with Syncing coordinates to Wikidata where the existing statement has a reference[edit]

I raised an issue with example edits on the Wikivoyage pub regarding how sync to Wikidata works for coordinates with an existing statement in Wikidata that has a reference. I provide a corresponding edit on Wikidata and EN Wikivoyage made with the Listing editor sync to wikidata of a coordinate. The value overwrites a Wikidata statement with a reference, but does not change the reference. This creates an erroneous statement. Please see the discussion on the travelers pub. If this my observation with coordinates syncing to Wikidata is correct, the remainder of synced fields should be reviewed for the same issue if there isn't an existing framework to check for existing references or deprecating existing statements that are being replaced. Wolfgang8741 (talk) 13:57, 31 March 2022 (UTC)[reply]

Additionally - edits made by the Listing Editor lack clear identification in the change comment or as a "tool tag" "Wikidata tool tag" like many other tools on Wikidata include to help identify and trace back issues. Currently edits by the Listing Editor just appear as though the user made the edit. Due to the potential large scale issues I would like to see something like the following in the change log to help with tracking down issues potentially introduced by a version of the Listing editor: Edit made by Listing Editor vX.x.x from EN Wikivoyage. Wolfgang8741 (talk) 14:02, 31 March 2022 (UTC)[reply]

"Add listing" not showing up on user page.[edit]

Swept in from the pub

I am currently working on the User:RonanHoogmoed/Rivierenland page, where so far I have been adding listings manually. To save time and add information to Wikidata as well, I would like to use the "add listing" button since it's more convenient than working with templates. Is there a way to enable this on my user page, or is this limited to main space pages? Thank you in advance. RonanHoogmoed (talk) 06:46, 17 October 2022 (UTC)[reply]

@RonanHoogmoed Hmmm. I didn't realize it was under User/ prefix (userspace). Could it be that "add listing" functionality is mainspace-limited? Maybe it's time to copy your draft to Rivierenland and see if the "add listing" option appears there? Piotrus (talk) 07:21, 17 October 2022 (UTC)[reply]
@RonanHoogmoed: The "add listing" feature is limited to mainspace only, but you can still edit a listing using the listing editor in your userspace. SHB2000 (talk | contribs | meta) 07:21, 17 October 2022 (UTC)[reply]
@SHB2000 Funny question: what is a listing editor? If there is no add listing button, I am copy pasting the code. Never noticed another way to add a listing. Piotrus (talk) 07:23, 17 October 2022 (UTC)[reply]
The listing editor is the editor that pops up when you click "edit" to the right of a listing. You'll need to have JavaScript enabled, though. SHB2000 (talk | contribs | meta) 07:57, 17 October 2022 (UTC)[reply]
@SHB2000 Ah, yes, we use it, but it's often frustrating for much conten there is no 'listification' button. 'Add listing' should be an option for all headings, and there should be a 'listify' button, which would cut the highlighted content and dump it into the listing editor (description) section. Piotrus (talk) 03:45, 18 October 2022 (UTC)[reply]
[edit conflict] There should be buttons above the edit window (for the wikitext mode, I have never tried the visual editor at Wikivoyage). One way to come around the problem is to open a mainspace page for editing, perhaps using a redlink, add listings and then copy the resulting wikitext to the user space draft and close the mainspace page tab without saving. I assume the listing editor (the small print "edit" link at listings) should work in user space – if there already is a listing on the page, that link wouldn't be confusing like the "add listing" links would be on a normal user page (I haven't checked). –LPfi (talk) 08:05, 17 October 2022 (UTC)[reply]
@Piotrus, these buttons appear only in the 2010 wikitext editor (which is what your students should default to, if they're not in the visual editor).
I don't think there is any real need to restrict the feature from the User: namespace. We could consider turning it on there. WhatamIdoing (talk) 22:43, 17 October 2022 (UTC)[reply]
I agree that there's no good reason not to enable it in userspace. Ikan Kekek (talk) 00:03, 18 October 2022 (UTC)[reply]
Good idea! How can we do this? Piotrus (talk) 03:47, 18 October 2022 (UTC)[reply]
Well... I was going to say that we ask @Andyrom75 or Wrh2, but then I looked at the code, and I think it already is.
@Piotrus, the listing editor responds to specific section headings. I see it at User:WhatamIdoing/sandbox#Do. I don't know why it's not appearing at User:RonanHoogmoed/Rivierenland#Eat. WhatamIdoing (talk) 05:52, 18 October 2022 (UTC)[reply]
WhatamIdoing & Co., notwithstanding I haven't checked the code, I recall that the logic of (not) showing the "[add listing]" link is that the "region/country article" are supposed to be developed describing its content with verbose text, while "city article" are supposed to be structured with listings. That said, if a listing is present on "region/country articles", listing editor works normally (regardless the presence of the "[add listing]" link); see Tuscany as an example. To "guess" the type of article, the code check the presence of specific section titles. --Andyrom75 (talk) 07:47, 18 October 2022 (UTC)[reply]
What Andyrom75 said... the listing editor isn't supposed to appear on region articles to prevent people from adding listings to those articles. If an article has any of the following headings, the editor is disabled: '#Cities', '#Other_destinations', '#Islands', '#print-districts'. User:RonanHoogmoed/Rivierenland#Other destinations causes the editor to think that page is a region article and thus disables the editor. See also Wikivoyage:Listing editor#Configuration DISALLOW_ADD_LISTING_IF_PRESENT. -- Ryan • (talk) • 02:37, 19 October 2022 (UTC)[reply]
@Andyrom75, Wrh2: Just a suggestion, but it might be worth considering adding the section headers "Cities and towns", "Settlements", "Towns" as many of our region articles use these section headers. Unfortunately, there will be a few cases like Canberra/Tuggeranong and Country ACT which has a "towns" header, but I suppose the same logic can be applied. SHB2000 (talk | contribs | meta) 06:56, 19 October 2022 (UTC)[reply]
I assume there are many more variants. I have seen "Municipalities". But are there many region articles that don't have Other destinations? I somebody has a database dump handy, one could collect all level-2 headings before Get in and check what names are used, perhaps sorting and counting on the combination of headings (so that "Cities"+"Bungos"+"Other destinations" would count different from only "Bungos"), to avoid having to worry about local heading names where there also is a standard heading that can be used. –LPfi (talk) 07:51, 19 October 2022 (UTC)[reply]
@SHB2000, what we do on it:voy is to standardize the articles in a way that the main sections would be always present. We can clearly add subsections if and where needed.
For example, in it:voy we use "Centri abitati" that indicates any group of people that lives in a certain area, this include anything between metropolis and villages. I don't know if a similar approach can be used also in en:voy. Not strictly related to the listing editor, but in general if it worth to create uniformity between the various articles of the same type (countries, cities, regions, parks, etc.). Andyrom75 (talk) 14:00, 20 October 2022 (UTC)[reply]
To add onto this, I see that pages like Gyeonggi and Jeju also make use of listings, despite being region pages. I did notice that there's way less of them so I will adjust this on my page for Rivierenland, but I agree that it would be beneficial if it is possible to add listings to the sections that are common on region articles, since it seems like this is already happening frequently despite the lack of the "Add listing" button. RonanHoogmoed (talk) 05:57, 21 October 2022 (UTC)[reply]
@RonanHoogmoed: It is happening frequently, but a large proportion of that is touting. Mostly the listings should be placed elsewhere. The advice on that in the guideline was recently rewritten, so it is natural that there are a lot of articles where the current guideline isn't followed, and quite much work done to get rid of those listings. I cannot judge whether having pass-by editors put listings in regions is better than them not being able to. With the button missing, some will put them in the right place instead, some listings that we don't want will not appear, and some listings we want will not appear. I have no feel for which cases dominate, and no idea on how to get figures on it. –LPfi (talk) 07:14, 21 October 2022 (UTC)[reply]
@Andyrom75 But what about items that are located outside any locations, in villages that don't need their own WV article, or just "out there"? Shouldn't they get a listing in the region/country (well, region, country will likely never need them)? Piotrus (talk) 03:06, 21 October 2022 (UTC)[reply]
See Wikivoyage:Listings#Listings outside a destination. In some cases they should be placed in the region article, but it is problematic (less important attractions and facilities in backwater villages get more prominence than the main attractions in the cities) and there are other options. –LPfi (talk) 07:14, 21 October 2022 (UTC)[reply]
Piotrus, I haven't said that is forbidden to use a listing in a region article, I've just said that in the large majority of the cases, is much more appropriate to insert verbose content in place of structured content; that's why the "add listing"-link is missing in those article. --Andyrom75 (talk) 07:55, 21 October 2022 (UTC)[reply]
@LPfi The way I look at it, the important attraction in cities will have good listing in articles about the cities. The current way seems to discriminate against attractions, some of which can be very important (even UNESCO level) that are not in big cities. Piotrus (talk) 08:41, 21 October 2022 (UTC)[reply]
Most UNESCO World Heritage Sites will have some sort of nearby small settlement. Take Joggins as an example – normally, the village wouldn't have its own article, but it does because of the world heritage site. Otherwise, they could be park articles. SHB2000 (talk | contribs | meta) 08:50, 21 October 2022 (UTC)[reply]
Note the first bullet in the linked guideline section: major points of interest can be included as "other destinations" in the region article. For minor attractions (some of which wouldn't be listed if they were in a city), listing them in the region article gives them excess prominence. LPfi (talk) 10:04, 21 October 2022 (UTC)[reply]

Listing editor doesn't work anymore[edit]

When I'm going to update the listings in Thiruvananthapuram, none of the two "edit" buttons seem to work (it was used to be a single "edit" button). I also can't add new listings by using "add listing". I have to use source editor to edit listings. Sbb1413 (he) (talkcontribs) 06:08, 28 October 2023 (UTC)[reply]

Worked for me. The two last edits on Nousiainen I did now were by the listing editor. –LPfi (talk) 17:16, 30 October 2023 (UTC)[reply]
I mostly use smartphone for editing and the listing editor had worked for me before. But as of 30 October 2023, none of the buttons of the editor ("edit", "add listing") seem to work for me except in rare cases. Sbb1413 (he) (talkcontribs) 17:49, 30 October 2023 (UTC)[reply]
Same for me in mobile mode. There are no buttons for editing or adding an individual listing. However, on desktop mode on my phone (and, I assume, on any computer), it still works normally. ThunderingTyphoons! (talk) 18:55, 30 October 2023 (UTC)[reply]
It does not work in either mode for me in my smartphone. Sbb1413 (he) (talkcontribs) 18:58, 30 October 2023 (UTC)[reply]
Well that's not ideal. Should this be a Phabricator report? ThunderingTyphoons! (talk) 20:31, 30 October 2023 (UTC)[reply]
It seems to depend on which browser you are using. I'm able to get the listing editor to work in desktop mode on my phone when using the Huawei mobile browser. It won't work on Microsoft Edge (mobile version), however. STW932 (talk) 04:06, 31 October 2023 (UTC)[reply]
It isn't working for me using Firefox on a Windows 11 PC. I have just failed to add a listing. The editor pops up, and edits appear to work, as they appear on the page that you are looking at, but they are not saved.
If anybody wants to test this it is important that they make a real edit and then open the page in another window and check that the edit is there. AlasdairW (talk) 23:31, 2 November 2023 (UTC)[reply]
I don't know what happened but now I'm also unable to get the listing editor to work in desktop mode on my phone when using the Huawei mobile browser (or any other mobile browser that I'm currently using). That's particularly troublesome for me, as I'm unable to access Wikivoyage on a PC (for reasons I have explained on Talk:China). So now the only way I can add a new listing is by copying another listing and deleting the content from it before adding content for the new listing. STW932 (talk) 12:26, 9 November 2023 (UTC)[reply]
The listing editor is working again on my Huawei mobile browser, though only when I open the page in desktop mode. I did an edit just now and my changes were saved successfully. For some reason, however, the listing editor is still not accessible on Microsoft Edge regardless of whether I am using desktop mode or mobile phone mode. STW932 (talk) 14:19, 23 November 2023 (UTC)[reply]
I recently purchased an iPad and I found that I am able to access Wikivoyage on that device by linking it to a hot spot on my mobile phone. I am also able to access the listing editor on the iPad's Safari browser (though I haven't yet made any edits with it). STW932 (talk) 14:27, 23 November 2023 (UTC)[reply]
I'm glad you've found a solution, at least for now. Hopefully at some point we can make the listing editor work in mobile mode. —Granger (talk · contribs) 16:00, 23 November 2023 (UTC)[reply]

Listing editor doesn't work anymore[edit]

Swept in from the pub

You are invited to join the discussion at Wikivoyage talk:Listing editor#Listing editor doesn't work anymore. Sbb1413 (he) (talkcontribs) 16:44, 30 October 2023 (UTC)[reply]

It looks like this might be affecting mobile/smartphone editors. WhatamIdoing (talk) 04:21, 31 October 2023 (UTC)[reply]

Edit listing issue[edit]

Swept in from the pub

I'm experiencing an issue where clicking the edit button for a specific listing in the guide opens the edit form for a different listing. Could this be a known bug or is it happening only on my end? Leoneix (talk) 14:45, 9 December 2023 (UTC)[reply]

This issue has forced me to use the source editor for editing listings, which while functional, lacks the user-friendliness of the dedicated listing editor interface. Leoneix (talk) 14:47, 9 December 2023 (UTC)[reply]
First try clearing your browser cache. I don't know what web browser you have but if you google this and then just add the name of your browser to the search words there'll be many sites with instructions. Brycehughes (talk) 14:58, 9 December 2023 (UTC)[reply]
Is it only happening in one article, or on all of them? WhatamIdoing (talk) 16:51, 9 December 2023 (UTC)[reply]
Yes it is happening to all the articles. Let be broadly describe the findings.
For example consider User:Leoneix/sandbox a guide.
While the edit option works as expected in section 1, opening the relevant listing editor for both Test1 and Test2, section 2 exhibits unexpected behavior. Clicking the edit option for Test3 opens the listing editor for Test1, not Test3 itself. This inconsistency continues with Test4, where the edit option functions correctly.
So it seems that the listing editor resets the sequence of the listings from each sections of guides.
I hope my explanation is understandable.
Also note that in the gadgets tab of preferences, the default ListingEditor2023 is selected. Leoneix (talk) 17:34, 9 December 2023 (UTC)[reply]
Clear your browser cache man. Brycehughes (talk) 19:34, 9 December 2023 (UTC)[reply]
All four of the items in your sandbox work for me. I tested in Firefox on macOS 12.7. What's your web browser and operating system? Do you have the same problem in a private/incognito window?
Nothing in m: User:Leoneix/global.js looks relevant to me. WhatamIdoing (talk) 04:38, 10 December 2023 (UTC)[reply]
I use Chrome On Windows 10 Pro. I have already cleared cache two times. Let me change the browser and see if the issue persists. Leoneix (talk) 04:40, 10 December 2023 (UTC)[reply]
Ok it works in Chrome incognito Leoneix (talk) 04:42, 10 December 2023 (UTC)[reply]
If it works in incognito mode, then it's usually a problem with a user script or gadget. Do you have any of the experimental things enabled in Special:Preferences#mw-prefsection-gadgets ? Have you tried blanking m: User:Leoneix/global.js ? (It seems unlikely to help, but it's a usual thing to try.) There might be more ideas of things to check at mw:safemode, but safemode itself won't work, because that disables the listing editor, too. WhatamIdoing (talk) 21:40, 10 December 2023 (UTC)[reply]
I will try disabling browser extensions to see if that works. Leoneix (talk) 04:09, 11 December 2023 (UTC)[reply]
There are a couple of Chrome extensions (ironically) that can help with quickly turning on/off extensions: Disable Extensions Temporarily, Extension Switch. Extensions are pesky. Brycehughes (talk) 07:42, 11 December 2023 (UTC)[reply]

Listing editor doesn't work again[edit]

Swept in from the pub

When I try to edit the listings in Chandrapur using listing editor, I'm unable to publish the edits. Sbb1413 (he) (talkcontribs) 08:22, 20 January 2024 (UTC)[reply]

Confirmed. I could only save using standard editing. —Justin (koavf)TCM 09:07, 20 January 2024 (UTC)[reply]
Today I could do 3 edits with the listing editor; when I tried to do one more, the listing editor did not work anymore. FredTC (talk) 11:52, 21 January 2024 (UTC)[reply]
@Andyrom75, do you see that as well?
ext.gadget.ListingEditorMain-script-0.js:776 Uncaught TypeError: Core.trimDecimal is not a function
at validateForm (ext.gadget.ListingEditorMain-script-0.js:776:39)
at HTMLFormElement.click (ext.gadget.ListingEditorMain-script-0.js:634:35)
at props.click (jquery.ui.dialog.js:381:12)
at HTMLButtonElement.dispatch (jquery.js:5145:27)
at elemData.handle (jquery.js:4949:28) -- andree 13:58, 21 January 2024 (UTC)[reply]
This problem persists - the listing editor can handle an outright deletion but not an update. The work-around is to edit the entire subsection as if in plain text. Grahamsands (talk) 21:53, 21 January 2024 (UTC)[reply]
The listing editors isn't working for me too, most of the time. Very odd. Gizza (roam) 23:20, 21 January 2024 (UTC)[reply]
I can confirm. It isn't working most of the time. OhanaUnitedTalk page 03:17, 22 January 2024 (UTC)[reply]
Same problem here. I cannot update a listing using the listing editor for some reason. Should we file a phabricator report? --SHB2000 (talk | contribs | meta) 23:40, 21 January 2024 (UTC)[reply]
Yes Done Doing it now. —Justin (koavf)TCM 01:56, 22 January 2024 (UTC)[reply]
They send the bug report back to us... OhanaUnitedTalk page 14:47, 22 January 2024 (UTC)[reply]
I think I have resolved this (and added some tests!). I am working out how to deploy new versions to a beta going forward with Andyrom75 and will push the new change as soon as we have worked that out and my user rights nomination has gone through. Jdlrobson (talk) 01:09, 27 January 2024 (UTC)[reply]
@Jon_(WMF):==@Jdlrobson: (? :-) ), seems that probably you introduced this in the recent change (or the other one)? BTW, any idea since when is ES6 enabled/supported on this wikipage? BTW @all, seems that also MediaWiki:Gadget-Carousel.js started failing with some syntax error. -- andree 18:19, 22 January 2024 (UTC)[reply]
That is very curious. Why does the code in MediaWiki:Gadget-ListingEditor2023Main.js contain a bunch of lines written in Italian (search for the sentence 'Facendo click su "Salva"')? It doesn't seem optimized and merits some code review. OhanaUnitedTalk page 22:21, 22 January 2024 (UTC)[reply]
it's maintained by andyrom (mainly on :it), and Jon - you can even find github link in the code... -- andree 05:24, 23 January 2024 (UTC)[reply]
I'd suggest some of you, admins (@SHB2000, @LPfi, someone else?) try to revert to the version before the changes - see if it helps. @Jon (WMF) or @Andyrom75 can re-revert, once they resolve the problem, once they have time for it... -- andree 09:21, 24 January 2024 (UTC)[reply]
I cannot revert the page – it needs an interface admin to do so. --SHB2000 (talk | contribs | meta) 10:54, 24 January 2024 (UTC)[reply]
Huh, OK, I thought Admin implies IF Admin... good to know... -- andree 11:13, 24 January 2024 (UTC)[reply]
I've reverted back to the last known working version (with staff account). I'll take a closer look over the weekend (as volunteer). Currently in process of adding tests which will hopefully minimize this sort of thing in future! Sorry for the disruption! Jdlrobson (talk) 17:05, 24 January 2024 (UTC)[reply]
User:OhanaUnited there are various forks of the code in different projects and all the gadgets are hard to maintain. I have volunteered to help address this problem so the gadget is more stable, and doesn;t break in future (it uses code that might be removed from MediaWiki at any time) I've been working to fold these changes back into the code. The Italian-language specific portion is a tiny fragment of the code and in fact allows editors to use the interface in different languages similar to Special:Preferences. The current code is much more optimized than it was, even with the Italian code I assure you :-) Jdlrobson (talk) 17:07, 24 January 2024 (UTC)[reply]
Not sure what happened @Jdlrobson:, I only see you changed MediaWiki:Gadget-ListingEditor2023.js, not the *Main one...? I think the changes in Main are the cause. In any case, it still fails for me, just differently :
jQuery.Deferred exception: Cannot read properties of undefined (reading 'SHOW_LAST_EDITED_FIELD') TypeError: Cannot read properties of undefined (reading 'SHOW_LAST_EDITED_FIELD')
at eval (https://en.wikivoyage.org/w/load.php?lang=en&modules=ext.gadget.ListingEditorMain&skin=vector&version=1907r:37:598)
at Array.forEach (<anonymous>)
at src (https://en.wikivoyage.org/w/load.php?lang=en&modules=ext.gadget.ListingEditorMain&skin=vector&version=1907r:37:559)
at eval (https://en.wikivoyage.org/w/load.php?lang=en&modules=ext.gadget.ListingEditor2023&skin=vector&version=tpt1b:3:892)
at mightThrow (https://en.wikivoyage.org/w/load.php?lang=en&modules=jquery%2Cmapbox&skin=vector&version=is486:45:648)
at process (https://en.wikivoyage.org/w/load.php?lang=en&modules=jquery%2Cmapbox&skin=vector&version=is486:46:309) u
-- andree 20:23, 24 January 2024 (UTC)[reply]
@Andree.sk, @Jdlrobson, although the new editor worked correctly for few months (and I've deeply tested it), now it fails both on en:voy and it:voy with the same error message. Andyrom75 (talk) 12:02, 25 January 2024 (UTC)[reply]
At the moment the edit-button does not even start the editor. FredTC (talk) 12:32, 25 January 2024 (UTC)[reply]
Yes, but the code still wasn't properly reverted to to pre-20-january version (when it was changed, and at the same time the editor started failing)... -- andree 12:38, 25 January 2024 (UTC)[reply]
@Andree.sk, Jon just rolled it back (temporary). Now Listing editor, restarted its normal work. Andyrom75 (talk) 14:15, 25 January 2024 (UTC)[reply]