User talk:Wrh2

From Wikivoyage
Jump to: navigation, search

For talk page messages from previous years see:

Exchange rate templates[edit]

Ryan, I have given up on the two experimental exchange rate templates I created as I couldn't get them to work. I am using an infobox instead. I think they should be deleted, but don't have the ability to do so. As a admin, could you do this, please? Thank you. I have used my infobox, by the way, to update the Nicaragua, Costa Rica, Belize, Guatemala and Honduras pages as a start. Regards, Ground Zero (talk) 21:57, 4 January 2017 (UTC)

I've deleted one of the two templates, and converted the other over to replace the infobox that's been added to various country articles. See Wikivoyage:Travellers' pub‎‎#Currencies, again for more details. -- Ryan • (talk) • 22:13, 4 January 2017 (UTC)
Thank you muchly. I will use the template instead. Unless I run into resistance for the changes I have made to the Central American articles, I will apply this to other countries with the aim of making it a standard place in countries articles for readers to find this information. Ground Zero (talk) 22:29, 4 January 2017 (UTC)

I like having the currencies optional. Thanks. I had tried removing the USD line, but that didn't work. I have also thought about adding one or two regional currencies for some countries where there may be a larger share of readers, e.g., Cdn $ for USA, Mexico; Aus$ for NZ, Indonesia; and SA rand for southern Africa. I guess I can copy the code down to create additional optional cornices, can i? Ground Zero (talk) 16:06, 5 January 2017 (UTC)

As noted in the pub, the current template is just a quick-and-dirty version that was meant to immediately replace the infoboxes. Feel free to add more currencies to the template, although if the template starts to get overly complex then some refactoring may be required. -- Ryan • (talk) • 16:09, 5 January 2017 (UTC)
I've added CAD to USA and Mexico, but not to others. When I get to Caribbean nations, I will probably add CAD there too.
I really appreciate your assistance on this.
Can I ask your opinion on a template for the eurozone? Should it show just USD and GBP, or should I add CAD and AUD too? I'm Canadian, so I don't trust my own instincts on this one. Thanks. Ground Zero (talk) 19:36, 5 January 2017 (UTC)
Re: currencies to show: that's probably a better question for the pub - I can help with the implementation, but can't provide much expertise on the subject matter. -- Ryan • (talk) • 19:50, 5 January 2017 (UTC)

Template:Exchange rate euros is another failed experiment. It should be deleted. I'm just not getting the hang of templates, unfortunately. Sorry to cause extra bother. Ground Zero (talk) 21:16, 7 January 2017 (UTC)

What is the goal with the new template? I assumed you were just trying to create something that could be used for all Eurozone countries, and tweaked it slightly to promote re-use of {{exchange rates}}. Is there something else it is supposed to do? -- Ryan • (talk) • 21:22, 7 January 2017 (UTC)
I see now that your tweaks made it work, and do exactly what it was supposed to do. Thanks. I can use that also for UKP, USD, CFA francs, and Eastern Caribbean dollars. Ground Zero (talk) 21:44, 7 January 2017 (UTC)
I have started a documentation page Template:Exchange rate euros/doc. As there are not really any parameters on this one, I have not added that. Please let me know if there is more I should do, or if there is somewhere I can read up on using templates. Ground Zero (talk) 22:52, 7 January 2017 (UTC)
mw:Help:Templates provides an overview of templates, although if you are stuck you can always just as in the Pub and plenty of people should be able to help. -- Ryan • (talk) • 23:06, 7 January 2017 (UTC)

Ryan, I am happy with whatever coding solution you think works best, and am willing to apply the template to articles when it is ready. I do get a bit frustrated, though, that some editors drop in on a discussion to indicate vaguely how something should be done differently, but dont seem to be willing to either provide specifics, or to assist you and me in doing the work. In updating exchange rates, I have found rates in articles that date as far back as 2007, although 2011 and after is more common. Meanwhile, there has been talk on the Currency talk page since 2011 about how to go about fixing it. My aim is to have all country articles updated to Jan 2017 by the end of the month, except for war zones, of course. Will I be around next January to update them again? Maybe. Be at least now there are links in the country articles to make updating the rates much easier should someone else be willing to take it on. And someday, I hope, Wikivoyage will reach the El Dorado of an automated solution that will render updating unnecessary, by in the meantime, we won't have lists of rates from 2013 that make WV look like a dead site. Thank you again for your help. <endrant> Ground Zero (talk) 21:09, 16 January 2017 (UTC)

@Ground Zero: I think anyone who contributes to a wiki regularly gets frustrated at times - since there isn't any authority hierarchy it can be very tough to make decisions and get things done, but it helps to remember that everyone contributing means well. I'll revisit {{exchange rates}} sometime soon and see what can be done to consolidate things further.
It's also worth noting that historically, most people who propose something like an exchange rate template tend to not follow through, thus I tend to be skeptical of those sorts of proposals. In this case I was skeptical when you started the discussion, but I've been pleasantly surprised to see you implement it in most of the country articles - you've proven to be a true exception. Thanks for your efforts! -- Ryan • (talk) • 03:49, 17 January 2017 (UTC)

Your skepticism is entirely warranted: wikis are littered with projects that have been started and abandoned. I think we've seen why nothing has happened with exchange rates for five years: there are a lot of people who want to direct the work, and so discussion goes on for a while until it grinds down and nothing is done, then a while later someone else takes a run at it and the cycle repeats. I guess I've been willing to step on toes to get this done, so now the only countries remaining are the 14 CFA and 8 EC countries. I'll look forward to seeing what you can do with the template. Thanks again for your work and support. Ground Zero (talk) 13:29, 17 January 2017 (UTC)

Ellipses[edit]

Hi, Ryan. Can I ask why your bot changes the ellipsis character to three periods? Powers (talk) 21:48, 8 January 2017 (UTC)

Replacing the non-ASCII ellipsis symbol with the ASCII equivalent of three dots is fairly standard practice (see w:MOS:ELLIPSIS) so I assumed that it would not be a controversial change. I've reverted the edit in question and removed that rule from the bot. -- Ryan • (talk) • 22:49, 8 January 2017 (UTC)
I wasn't asking for a reversion; I was just curious what the rationale was. I'm not sure I agree with Wikipedia's analysis of the character's drawbacks but I'm willing to use periods if it's considered better. Powers (talk) 01:32, 9 January 2017 (UTC)

Wikivoyage talk:Internal links[edit]

I disagree with this edit to Wikivoyage_talk:Internal_links. The original comment, left by another user, was "[[Mos]], while actually one of the few useful shortcuts we have, is a town in Spain. [[Apt]] is a town and canton in France. [[As]] are towns in Belgium, Norway, Finland and the Czech Republic. [[Tone]] is a town in Japan. [[IL]], I'd say it should redirect to either Illinois or Israel, but no, it goes to this page." The whole point of that comment is that the original poster dislikes policy shortcuts in mainspace where they can be mistaken for geographic place names. Change [[IL]] to [[WV:IL]] and that meaning is lost. In any case, changing comments left by others is a bad idea if there's any risk that an edit (or even a refactoring) will change the meaning of the text. I haven't reverted your edit, but you may want to look at the text and see if it still makes any sense? Thanks. K7L (talk) 05:10, 15 January 2017 (UTC)

I've reverted that edit - it was done while updating links prior to deleting a redirect, so I hadn't read through the discussions in question. -- Ryan • (talk) • 06:41, 15 January 2017 (UTC)

deletion[edit]

why? --Garvysolaz (talk) 22:14, 27 January 2017 (UTC)

Altrincham[edit]

Altfish (talk) 11:03, 30 January 2017 (UTC) I think I've sorted all the dead links on the Altrincham page

Potential false positive for dead link bot[edit]

Hi Ryan,

I found a link which was marked as a dead link by your bot, but actually wasn't. Since you asked to know about any such cases, I thought I'd point it out to you. It's in Zarma phrasebook and it concerns the last link Zarma-French-English dictionary.Drat70 (talk) 03:07, 8 February 2017 (UTC)

I found another one at Fischland-Darß-Zingst which links to http://www.bunte-stube.de/ Drat70 (talk) 06:08, 8 February 2017 (UTC)
Frankly I am more concerned about false negatives than false positives, but it's good to know about both. Hobbitschuster (talk) 20:54, 8 February 2017 (UTC)
From here, bisharat.net looks dead (its whois lists ns11.bravehost.com and ns12.bravehost.com as DNS, but neither is responding); www.bunte-stube.de looks to be up. Dunno. K7L (talk) 05:08, 9 February 2017 (UTC)

Dead link bot for de-WV[edit]

Hi.

I recently had a debate on de-WV here where I said, I could ask you whether the dead weblink bot can be changed for the German language. It appears that there is interest to have that bot there. So this is me asking you whether that would be possible and if so, how. Hobbitschuster (talk) 22:14, 1 March 2017 (UTC)

Dead link bot for ru-WV[edit]

Hey Ryan, Russian WV has the same request as de-WV. (Its discussion can be found here). Is it possible for you to run this bot on voy:ru: or share its code? Thanks! --Kiaora (talk) 12:23, 9 June 2017 (UTC)

@Kiaora: At this time I have chosen to retire from Wikivoyage. If you would like I can provide you the code for the dead-links bot (it is written in java using the wiki-java framework), but it isn't well-tested on a non-English site so you may be better off working with some of the bot authors on Wikipedia to re-use one of their dead link bots. -- Ryan • (talk) • 17:39, 12 June 2017 (UTC)
Thanks for taking time to answer this. And yes, if possible, post the source code somewhere please. This way I'll have one more option to choose from. And just to mention, I already had a look at a few other scripts on wikipedia but I was reluctant to use them as I was hoping your one will be easier to adapt. Thanks again! --Kiaora (talk) 17:47, 12 June 2017 (UTC)
@Kiaora: I've uploaded the code to [1]. -- Ryan • (talk) • 04:28, 29 June 2017 (UTC)
Fantastic, thanks! I just tried to run it in ru-WV and it worked. Much appreciated for providing it! --Kiaora (talk) 16:58, 6 July 2017 (UTC)

Do not block me[edit]

Wrh2, please do not block me because I am editing Wikivoyage. I will not stop editing until your calm. 70.71.90.6 03:23, 23 April 2017 (UTC)

I don't know what in the world you're talking about, but thanks for linking to your contribution history because you're most definitely going to be blocked now that I've seen it. -- AndreCarrotflower (talk) 06:24, 23 April 2017 (UTC)

Listing editor will start next week on German Wikivoyage[edit]

Of course, it took some time to have a listing editor (we name it vCard editor) at the German Wikivoyage because the [wv/de] vCard template is more complex then the [wv/en] template and DerFussi and me are the only one who are programmers, too. We will activate it on next Wednesday.

I would propose the following changes in the listing editors script:

From (i18n)

		var _wikidataLabel = function(jsonObj, value) {
			var entityObj = _wikidataEntity(jsonObj, value);
			if (!entityObj || !entityObj.labels || !entityObj.labels.en) {
				return null;
			}
			return entityObj.labels.en.value;
		};

to

		var _wikidataLabel = function(jsonObj, value) {
			var entityObj = _wikidataEntity(jsonObj, value);
			if (!entityObj || !entityObj.labels || !entityObj.labels[ListingEditor.Config.LANG]) { /* mod */
				return null;
			}
			return entityObj.labels[ListingEditor.Config.LANG].value;
		};

And from (Do not perform listing validations when deleting a listing)

					{
						text: ListingEditor.Config.TRANSLATIONS.submit, click: function() {
							if (validateForm()) {
								formToText(mode, listingTemplateWikiSyntax, listingTemplateAsMap, sectionNumber);
								$(this).dialog('close');
							}
						}
					},

to

					{
						text: ListingEditor.Config.TRANSLATIONS.submit,
						title: ListingEditor.Config.TRANSLATIONS.submitTitle,
						click: function() {
							if ($(ListingEditor.Config.EDITOR_CLOSED_SELECTOR).is(':checked')) {
								// no validation
								formToText(mode, listingTemplateWikiSyntax, listingTemplateAsMap, sectionNumber);
								$(this).dialog('close');
							}
							else if (validateForm()) {
								formToText(mode, listingTemplateWikiSyntax, listingTemplateAsMap, sectionNumber);
								$(this).dialog('close');
							}
						}
					},

And from (Add mouse cursor back to price after clicking currency sign)

		var initCurrencySymbolFormFields = function(form, mode) {
			var CURRENCY_SIGNS_SELECTOR = '.currency-signs';
			$(CURRENCY_SIGNS_SELECTOR, form).click(function() {
				var priceInput = $('#input-price');
				var caretPos = priceInput[0].selectionStart;
				var oldPrice = priceInput.val();
				var currencySymbol = $(this).find('a').text();
				var newPrice = oldPrice.substring(0, caretPos) + currencySymbol + oldPrice.substring(caretPos);
				priceInput.val(newPrice);
			});
		};

to

		var initCurrencySymbolFormFields = function(form, mode) {
			var CURRENCY_SIGNS_SELECTOR = '.currency-signs';
			$(CURRENCY_SIGNS_SELECTOR, form).click(function() {
				var priceInput = $('#input-price');
				var caretPos = priceInput[0].selectionStart;
				var oldPrice = priceInput.val();
				var currencySymbol = $(this).find('a').text();
				var newPrice = oldPrice.substring(0, caretPos) + currencySymbol + oldPrice.substring(caretPos);
				priceInput.val(newPrice);
				priceInput.select();
				// now setting the cursor behind the currency symbol inserted
				priceInput[0].setSelectionRange(caretPos + 1, caretPos + 1);
			});
		};

Now I am not really sure if a mobile version could be possible because I do no know if ajax, jquery.ui.dialog, and jquery.ui.autocomplete will work. --RolandUnger (talk) 11:27, 25 June 2017 (UTC)

Thanks for the suggestions @RolandUnger:. I am no longer actively maintaining the listing editor, but @Andyrom75: has been very active in editing the code and may be able to assist. -- Ryan • (talk) • 04:30, 29 June 2017 (UTC)
Thanks for your answer. I will contact @Andyrom75:. The biggest challenge would be the adaption to the mobile version because the Jquery UI modules are deprecated and not working. --RolandUnger (talk) 04:34, 29 June 2017 (UTC)
First of all I'd like to spend few seconds on thanking Ryan for all his great contributions, not only to listing editor, and I was sorry to read that he's about to quit (or at least to reduce significantly) his Wikivoyage presence. Ryan is a great person and technical expert.
That said, let's come to Roland 3 points.
  1. If I remember correctly, I've tested your changes in it:voy but I've left entityObj.labels.en because in various cases existed the English label and not the Italian one. By the way we can modify the code to use the local one if exists and if not the English one.
  2. Since the body of the two if is the same and considering that if the first variable of an or operator is true the second one won't be tested, we can just modify as follow: "$(ListingEditor.Config.EDITOR_CLOSED_SELECTOR).is(':checked') || validateForm()"
  3. I haven't tested it (now I'm in rush ... sorry) but I think it's fine and useful, although I would extend the possibility of adding symbols to all the field with a custom set of chars. --Andyrom75 (talk) 17:39, 29 June 2017 (UTC)
I made all this as a proposal. These proposals were derived from our Listing Editor fork.
By the way, yesterday Jon Robson from WMF told me that there is no way to load jquery.ui.dialog and jquery.ui.autocomplete in the Minerva mobile skin. In the current state the Listing Editor will never run in that skin. Also the people making the ResourceLoader could not help because they are not familiar with the MobileFrontend. Yesterday I started to replace the appropriate calls. --RolandUnger (talk) 04:29, 30 June 2017 (UTC)
Roland, the purpose of my comment is to find a common solution suitable for all the language versions, in order to avoid to have different script. Please share your thoughts about the comments above. --Andyrom75 (talk) 05:52, 30 June 2017 (UTC)

Wrh2Bot errors[edit]

Hi Wrh2, User:Wrh2Bot has been removing dead link templates from links that are still dead, in articles such as Barbuda and Charlotte. I think it might be better to leave the templates there for a human to review rather than removing them by bot, to avoid errors like this. —Granger (talk · contribs) 21:03, 23 September 2017 (UTC)

The Barbuda & Charlotte links you cited are not dead - to cite one example, [2] returns a 200 and redirects to advertising. The bot can only determine if a link is dead, but if it is active there is no way to determine whether the content at the other end of the link is actually relevant or not. -- Ryan • (talk) • 21:08, 23 September 2017 (UTC)
Maybe my phrasing was unclear, but that's exactly my point. Once a link has been marked as dead, if a new website appears at the same URL, there's a good chance that it's a domain squatter rather than the original website. Because the bot can't tell the difference, I think it should leave the templates there for human review rather than removing them. —Granger (talk · contribs) 21:18, 23 September 2017 (UTC)
I appreciate the feedback, but when this was discussed previously people raised concerns about sites that were down temporarily, and wanted assurance that if a site came back online that the bot would no longer mark it as dead. If this is a major concern let me know and I can halt the bot - it is running now only because of the request at Wikivoyage:Collaboration of the month#Category:Articles with dead external links. -- Ryan • (talk) • 21:20, 23 September 2017 (UTC)
Hmm, I only see one user raising a concern like that in the discussion you linked, and their original suggestion was checking links a few days apart (which I think is not a bad idea), not months later. Meanwhile, at Category talk:Articles with dead external links#Dead links bot, at least two other users seem to have raised the same concern I have. I think it is much worse to remove a "dead link" template from a link that goes to a domain squatter than to leave a "dead link" template on a site that has come back to life, because the second case can easily be detected and fixed by someone going through the dead link category whereas the first is more difficult to detect. Moreover, I suspect that domain squatters are more common than sites that come back to life. If you're not willing to make the change, I think it would be better to halt the bot, pending discussion of this issue. I'd be happy to start such a discussion in the pub. —Granger (talk · contribs) 21:29, 23 September 2017 (UTC)
I've disabled the bot. -- Ryan • (talk) • 21:32, 23 September 2017 (UTC)
Thanks! I've started a discussion in the pub. —Granger (talk · contribs) 21:45, 23 September 2017 (UTC)